bootandy/archived-dust
1
0
Fork 0
mirror of https://github.com/bootandy/dust.git synced 2026-06-08 11:29:05 +03:00
Code Issues 21 Packages Projects Releases 10 Wiki Activity

[GH-ISSUE #420] Handle ErrorKind::Interruped in walk #182

New Issue
Closed
opened 2026-06-08 11:26:01 +03:00 by zhus · 2 comments
zhus commented 2026-06-08 11:26:01 +03:00
Owner
Copy Link
Copy Source

Originally created by @wezm on GitHub (Jul 19, 2024).
Original GitHub issue: https://github.com/bootandy/dust/issues/420

While scanning a hierarchy dust reported an ErrorKind::Interruped error.

EINTR

It appears this originates in:

https://github.com/bootandy/dust/blob/dbd18f90e7b184d12f14533e76e5915dbe4a2051/src/dir_walker.rs#L240

As per the docs I think this error should be detected and the read_dir tried again.

There's also some guidance in the Read trait docs:

An error of the ErrorKind::Interrupted kind is non-fatal and the read operation should be retried if there is nothing else to do.

Originally created by @wezm on GitHub (Jul 19, 2024). Original GitHub issue: https://github.com/bootandy/dust/issues/420 While scanning a hierarchy `dust` reported an `ErrorKind::Interruped` error. <img width="1423" alt="EINTR" src="https://github.com/user-attachments/assets/c747df93-3414-4736-b8d5-5683fb5b5317"> It appears this originates in: https://github.com/bootandy/dust/blob/dbd18f90e7b184d12f14533e76e5915dbe4a2051/src/dir_walker.rs#L240 As per the [docs](https://doc.rust-lang.org/std/io/enum.ErrorKind.html#variant.Interrupted) I think this error should be detected and the `read_dir` tried again. There's also some guidance in the [`Read` trait docs](https://doc.rust-lang.org/std/io/trait.Read.html#errors): > An error of the [ErrorKind::Interrupted](https://doc.rust-lang.org/std/io/enum.ErrorKind.html#variant.Interrupted) kind is non-fatal and the read operation should be retried if there is nothing else to do.
zhus closed this issue 2026-06-08 11:26:01 +03:00
zhus commented 2026-06-08 11:26:02 +03:00
Author
Owner
Copy Link
Copy Source

@bootandy commented on GitHub (Jan 26, 2025):

Fixed on master, will go out in next release

<!-- gh-comment-id:2614332923 --> @bootandy commented on GitHub (Jan 26, 2025): Fixed on master, will go out in next release
zhus commented 2026-06-08 11:26:02 +03:00
Author
Owner
Copy Link
Copy Source

@wezm commented on GitHub (Jan 28, 2025):

Thank you 👍

<!-- gh-comment-id:2617096250 --> @wezm commented on GitHub (Jan 28, 2025): Thank you 👍
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
 windows help wanted
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
zhus (Sergey Zhukov)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bootandy/archived-dust#182
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?