[PR #39] [CLOSED] Clippy #267

New Issue

2026-06-08T11:26:36+03:00

zhus commented

2026-06-08 11:26:36 +03:00

📋 Pull Request Information

Original PR: https://github.com/bootandy/dust/pull/39
Author: @lespea
Created: 11/21/2019
Status: ❌ Closed

Base: master ← Head: clippy

📝 Commits (2)

fdc59f0 Fix clippy issues
bfc1eb1 Don't force a full collection when doing reverse

📊 Changes

6 files changed (+31 additions, -25 deletions)

View changed files

📝 Cargo.lock (+7 -0)
📝 Cargo.toml (+1 -1)
📝 src/display.rs (+16 -17)
📝 src/main.rs (+1 -2)
📝 src/utils/mod.rs (+1 -1)
📝 src/utils/platform.rs (+5 -4)

📄 Description

Fixes a bunch of clippy warnings which includes:

Don't box the Nodes (not needed since it's inside a vec)
Reversing the node children no longer requires collecting everything into an intermediary vec

Let me know if some of these changes you don't want (specifically the collapsed if-then-else branches you may prefer the original... I just went for cleaning everything for a first pass.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/bootandy/dust/pull/39 **Author:** [@lespea](https://github.com/lespea) **Created:** 11/21/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `clippy` --- ### 📝 Commits (2) - [`fdc59f0`](https://github.com/bootandy/dust/commit/fdc59f0be7f00688fd7d37faa990558e9b037998) Fix clippy issues - [`bfc1eb1`](https://github.com/bootandy/dust/commit/bfc1eb164a2f4e2204ecd49721c8f00610ee7c35) Don't force a full collection when doing reverse ### 📊 Changes **6 files changed** (+31 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+7 -0) 📝 `Cargo.toml` (+1 -1) 📝 `src/display.rs` (+16 -17) 📝 `src/main.rs` (+1 -2) 📝 `src/utils/mod.rs` (+1 -1) 📝 `src/utils/platform.rs` (+5 -4) </details> ### 📄 Description Fixes a bunch of clippy warnings which includes: * Don't box the Nodes (not needed since it's inside a vec) * Reversing the node children no longer requires collecting everything into an intermediary vec Let me know if some of these changes you don't want (specifically the collapsed if-then-else branches you may prefer the original... I just went for cleaning everything for a first pass. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

zhus added the pull-request label 2026-06-08 11:26:36 +03:00

zhus closed this issue

2026-06-08 11:26:37 +03:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: bootandy/archived-dust#267