bootandy/archived-dust
1
0
Fork 0
mirror of https://github.com/bootandy/dust.git synced 2026-06-08 11:29:05 +03:00
Code Issues 21 Packages Projects Releases 10 Wiki Activity

[PR #61] [MERGED] Fix get_metadata on windows #281

New Issue
Closed
opened 2026-06-08 11:26:44 +03:00 by zhus · 0 comments
zhus commented 2026-06-08 11:26:44 +03:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bootandy/dust/pull/61
Author: @lespea
Created: 1/21/2020
Status: ✅ Merged
Merged: 1/22/2020
Merged by: @bootandy

Base: master ← Head: fixWinBreaks

📝 Commits (1)

  • 0c7b05f Fix get_metadata on windows

📊 Changes

3 files changed (+31 additions, -14 deletions)

View changed files

📝 Cargo.lock (+10 -0)
📝 Cargo.toml (+3 -0)
📝 src/utils/platform.rs (+18 -14)

📄 Description

The MetadataExt functions are nightly-only right now so we need to call
the windows api ourselves to get the device number. The winapi_util
package has a nice wrapper to do this for us.

The get_device function doesn't appear to be used anywhere so I removed
it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bootandy/dust/pull/61 **Author:** [@lespea](https://github.com/lespea) **Created:** 1/21/2020 **Status:** ✅ Merged **Merged:** 1/22/2020 **Merged by:** [@bootandy](https://github.com/bootandy) **Base:** `master` ← **Head:** `fixWinBreaks` --- ### 📝 Commits (1) - [`0c7b05f`](https://github.com/bootandy/dust/commit/0c7b05fec9f503ac63d0f75cb456ee931d4304aa) Fix get_metadata on windows ### 📊 Changes **3 files changed** (+31 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+10 -0) 📝 `Cargo.toml` (+3 -0) 📝 `src/utils/platform.rs` (+18 -14) </details> ### 📄 Description The MetadataExt functions are nightly-only right now so we need to call the windows api ourselves to get the device number. The winapi_util package has a nice wrapper to do this for us. The get_device function doesn't appear to be used anywhere so I removed it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
zhus added the pull-request label 2026-06-08 11:26:44 +03:00
zhus closed this issue 2026-06-08 11:26:45 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
 windows help wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
zhus (Sergey Zhukov)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bootandy/archived-dust#281
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?