[PR #62] [MERGED] Fix windows compilation and testing #283

New Issue

2026-06-08T11:26:46+03:00

zhus commented

2026-06-08 11:26:46 +03:00

📋 Pull Request Information

Original PR: https://github.com/bootandy/dust/pull/62
Author: @rivy
Created: 1/22/2020
Status: ✅ Merged
Merged: 2/3/2020
Merged by: @bootandy

Base: master ← Head: add.gha

📝 Commits (10+)

1851013 Maint/CI ~ add GitHub-Actions CI (aka GHA)
7c34389 Fix ~ improve portability of path manipulation
416ad51 Tests ~ fix windows testing
684994e Tests ~ disable two symlink tests which may not be possible on 'windows'
5ac1688 Tests ~ temporarily disable tests which vary by 'windows' hosts
0898ee6 Maint/CI ~ temporarily disable non-working cargo tarpaulin test coverage
26ef8c3 Tests ~ add test case to 'Fix ~ improve portability of path manipulation'
affafcc Tests ~ simplify by ignoring instead of skipping tests for 'Tests ~ temporarily disable tests which vary by 'windows' hosts'
1af6e1f Tests ~ simplify by ignoring instead of skipping tests for 'Tests ~ disable two symlink tests which may not be possible on 'windows''
7a38a26 Fix ~ (WinAPI) must use Handle::from_path_any() if target path might be a directory

📊 Changes

5 files changed (+438 additions, -19 deletions)

View changed files

➕ .github/workflows/CICD.yml (+286 -0)
📝 src/display.rs (+4 -1)
📝 src/tests.rs (+79 -0)
📝 src/utils/mod.rs (+67 -16)
📝 src/utils/platform.rs (+2 -2)

📄 Description

adds GitHub-Actions CI workflow (includes arm-linux, x86-linux, macos, and windows builds/testing)
- automatic deployment to Github Releases when commit is version tagged (see example at https://github.com/rivy/rs.dust/releases/tag/v0.4.9; note: fully automatically generated)
improves path manipulation portability
builds / tests successfully locally and on all CI hosts
wip / needs further investigation
- feasability of (currently disabled) symlink tests on "windows"
- investigate and/or update tests to handle minor size variations in testing output for different "windows" hosts
  - some one byte differences between local and CI host file sizes; ? bug or expected host variation
- cargo tarpaulin inability to handle test coverage (use alternate framework?)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/bootandy/dust/pull/62 **Author:** [@rivy](https://github.com/rivy) **Created:** 1/22/2020 **Status:** ✅ Merged **Merged:** 2/3/2020 **Merged by:** [@bootandy](https://github.com/bootandy) **Base:** `master` ← **Head:** `add.gha` --- ### 📝 Commits (10+) - [`1851013`](https://github.com/bootandy/dust/commit/18510130d8f291139711bead320bca6865926734) Maint/CI ~ add GitHub-Actions CI (aka GHA) - [`7c34389`](https://github.com/bootandy/dust/commit/7c34389aeaf3afbefbdf1ba14cdcd4c2ef42085c) Fix ~ improve portability of path manipulation - [`416ad51`](https://github.com/bootandy/dust/commit/416ad517fe0ac4760084f29ec3d4c288b78f2f5a) Tests ~ fix windows testing - [`684994e`](https://github.com/bootandy/dust/commit/684994ee1176196b9cd53815944b77191b0ed58c) Tests ~ disable two symlink tests which may not be possible on 'windows' - [`5ac1688`](https://github.com/bootandy/dust/commit/5ac168868e6150b0b6cda3182d65dac3d0694738) Tests ~ temporarily disable tests which vary by 'windows' hosts - [`0898ee6`](https://github.com/bootandy/dust/commit/0898ee6bf09c344e65e6761d6c6aec8ad3408366) Maint/CI ~ temporarily disable non-working `cargo tarpaulin` test coverage - [`26ef8c3`](https://github.com/bootandy/dust/commit/26ef8c3e593cec615301b1ad8e04d214663b413b) Tests ~ add test case to 'Fix ~ improve portability of path manipulation' - [`affafcc`](https://github.com/bootandy/dust/commit/affafcc5f2794ed69a6d8fb31f4e0b2c3e587560) Tests ~ simplify by ignoring instead of skipping tests for 'Tests ~ temporarily disable tests which vary by 'windows' hosts' - [`1af6e1f`](https://github.com/bootandy/dust/commit/1af6e1f757dd470260f849e930e2cf2b35f3f609) Tests ~ simplify by ignoring instead of skipping tests for 'Tests ~ disable two symlink tests which may not be possible on 'windows'' - [`7a38a26`](https://github.com/bootandy/dust/commit/7a38a2659351f29963aaaa0615558c2b535f51ab) Fix ~ (WinAPI) must use `Handle::from_path_any()` if target path might be a directory ### 📊 Changes **5 files changed** (+438 additions, -19 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/CICD.yml` (+286 -0) 📝 `src/display.rs` (+4 -1) 📝 `src/tests.rs` (+79 -0) 📝 `src/utils/mod.rs` (+67 -16) 📝 `src/utils/platform.rs` (+2 -2) </details> ### 📄 Description - adds GitHub-Actions CI workflow (includes arm-linux, x86-linux, macos, and windows builds/testing) - automatic deployment to Github Releases when commit is version tagged (see example at <https://github.com/rivy/rs.dust/releases/tag/v0.4.9>; note: fully automatically generated) - improves path manipulation portability - builds / tests successfully locally and on all CI hosts - wip / needs further investigation - feasability of (currently disabled) symlink tests on "windows" - investigate and/or update tests to handle minor size variations in testing output for different "windows" hosts - some one byte differences between local and CI host file sizes; ? bug or expected host variation - `cargo tarpaulin` inability to handle test coverage (use alternate framework?) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

zhus added the pull-request label 2026-06-08 11:26:46 +03:00

zhus closed this issue

2026-06-08 11:26:48 +03:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: bootandy/archived-dust#283