[PR #81] [MERGED] Maint/CI ~ fix features option for GHA cargo ... and cross ... #295

New Issue

2026-06-08T11:26:52+03:00

zhus commented

2026-06-08 11:26:52 +03:00

📋 Pull Request Information

Original PR: https://github.com/bootandy/dust/pull/81
Author: @rivy
Created: 3/10/2020
Status: ✅ Merged
Merged: 3/15/2020
Merged by: @bootandy

Base: master ← Head: fix.cicd-features

📝 Commits (1)

c3415df Maint/CI ~ fix features option for GHA cargo ... and cross ...

📊 Changes

1 file changed (+14 additions, -3 deletions)

View changed files

📝 .github/workflows/CICD.yml (+14 -3)

📄 Description

This fixes the failing empty features issue more generically and robustly.

I just noticed the GHA builds were failing on another repo and created this fix. I see that you've fixed it here by removing support for the features option completely. This implementation works whether the build uses features or not. It'll be more robust in the case that you add any features option at a later date.

Since, you're current implementation works, I understand if you don't want to merge this ... but I think that this is a better version which a future you might appreciate. 😄

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/bootandy/dust/pull/81 **Author:** [@rivy](https://github.com/rivy) **Created:** 3/10/2020 **Status:** ✅ Merged **Merged:** 3/15/2020 **Merged by:** [@bootandy](https://github.com/bootandy) **Base:** `master` ← **Head:** `fix.cicd-features` --- ### 📝 Commits (1) - [`c3415df`](https://github.com/bootandy/dust/commit/c3415df4b1a1eb761f51dc3893b7bcca0f64fc69) Maint/CI ~ fix features option for GHA `cargo ...` and `cross ...` ### 📊 Changes **1 file changed** (+14 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/CICD.yml` (+14 -3) </details> ### 📄 Description This fixes the failing empty features issue more generically and robustly. I just noticed the GHA builds were failing on another repo and created this fix. I see that you've fixed it here by removing support for the features option completely. This implementation works whether the build uses features or not. It'll be more robust in the case that you add any features option at a later date. Since, you're current implementation works, I understand if you don't want to merge this ... but I think that this is a better version which a future you might appreciate. 😄 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

zhus added the pull-request label 2026-06-08 11:26:52 +03:00

zhus closed this issue

2026-06-08 11:26:53 +03:00

zhus referenced this issue

2026-06-08 11:28:57 +03:00

[PR #487] [MERGED] Fix miscalculation of NTFS mount file sizes inside WSL #510

Sign in to join this conversation.