[PR #121] [MERGED] Cleanup #317

New Issue

2026-06-08T11:27:06+03:00

zhus commented

2026-06-08 11:27:06 +03:00

📋 Pull Request Information

Original PR: https://github.com/bootandy/dust/pull/121
Author: @baile320
Created: 10/5/2020
Status: ✅ Merged
Merged: 10/22/2020
Merged by: @bootandy

Base: master ← Head: cleanup

📝 Commits (8)

534f650 remove unneeded identity .map()
459d386 remove redunant field name in struct
bb9a5a6 impl num_siblings for Node
ca266cf replace nested if w/ match in get_tree_chars
ba1e775 remove unneeded field name in struct
4077702 remove redundant println! & logic in display_node
2354b7c make get_children_from_node a Node method
ba73a6f Revert "remove redundant println! & logic in display_node"

📊 Changes

2 files changed (+34 additions, -39 deletions)

View changed files

📝 src/display.rs (+17 -38)
📝 src/utils/mod.rs (+17 -1)

📄 Description

Hi, I'm practicing Rust and just wondering if you'd be interested in a PR with some cleanup changes? I was just reading through the code and noticed some things that might make things more readable or idiomatic, so I thought I would throw a PR out there.

There might be more stuff I can find (or go further w/ the few changes I made already - probably there are better ways to do some of them) but I wanted to see if you're interested in accepting this type of PR before I investigate further. Thanks :)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/bootandy/dust/pull/121 **Author:** [@baile320](https://github.com/baile320) **Created:** 10/5/2020 **Status:** ✅ Merged **Merged:** 10/22/2020 **Merged by:** [@bootandy](https://github.com/bootandy) **Base:** `master` ← **Head:** `cleanup` --- ### 📝 Commits (8) - [`534f650`](https://github.com/bootandy/dust/commit/534f65069d51c45d9d3e4e6b662ce4b33f942a02) remove unneeded identity .map() - [`459d386`](https://github.com/bootandy/dust/commit/459d386e43aee9c9fad8ba867784ff22c52b5299) remove redunant field name in struct - [`bb9a5a6`](https://github.com/bootandy/dust/commit/bb9a5a68fb83a065f296da55e531a5d30088bef3) impl num_siblings for Node - [`ca266cf`](https://github.com/bootandy/dust/commit/ca266cf6050aa7da8f6c43e5bec050f2710faf62) replace nested if w/ match in get_tree_chars - [`ba1e775`](https://github.com/bootandy/dust/commit/ba1e775b927f9a44b6f92127bf46cda2c07bd34e) remove unneeded field name in struct - [`4077702`](https://github.com/bootandy/dust/commit/40777025d5ccc519c34edc7cf6bd6afe3e76824e) remove redundant println! & logic in display_node - [`2354b7c`](https://github.com/bootandy/dust/commit/2354b7c4b142dde792aa7204ec18855213a6cab1) make get_children_from_node a Node method - [`ba73a6f`](https://github.com/bootandy/dust/commit/ba73a6f041c42f2ae73a04fc1c48735087c1b6ec) Revert "remove redundant println! & logic in display_node" ### 📊 Changes **2 files changed** (+34 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `src/display.rs` (+17 -38) 📝 `src/utils/mod.rs` (+17 -1) </details> ### 📄 Description Hi, I'm practicing Rust and just wondering if you'd be interested in a PR with some cleanup changes? I was just reading through the code and noticed some things that might make things more readable or idiomatic, so I thought I would throw a PR out there. There might be more stuff I can find (or go further w/ the few changes I made already - probably there are better ways to do some of them) but I wanted to see if you're interested in accepting this type of PR before I investigate further. Thanks :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

zhus added the pull-request label 2026-06-08 11:27:06 +03:00

zhus closed this issue

2026-06-08 11:27:06 +03:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: bootandy/archived-dust#317