[PR #436] [MERGED] refactor: simplify get_height_of_terminal() and get_width... #484

New Issue

2026-06-08T11:28:42+03:00

zhus commented

2026-06-08 11:28:42 +03:00

📋 Pull Request Information

Original PR: https://github.com/bootandy/dust/pull/436
Author: @muzimuzhi
Created: 8/30/2024
Status: ✅ Merged
Merged: 9/17/2024
Merged by: @bootandy

Base: master ← Head: simplify-get-terminal-wh

📝 Commits (1)

c85230a refactor: simplify get_height_of_terminal() and get_width...

📊 Changes

1 file changed (+3 additions, -7 deletions)

View changed files

📝 src/main.rs (+3 -7)

📄 Description

The https://github.com/eminence/terminal-size/pull/41 PR mentioned in comments of get_(height|width)_of_terminal() (added by https://github.com/bootandy/dust/commit/c36ca33fe973657002905bbdb77c639ac3c006f0)

https://github.com/bootandy/dust/blob/b63608604a768386506b6736f56092583e8fa5a0/src/main.rs#L83-L91

has been merged and shipped since terminal-size v0.2.2. As we're using terminal-size v0.2.6 now, it's time to simplify them.

https://github.com/bootandy/dust/blob/38c4d237321dcdb4f71f1918ec1cb473ed66655b/Cargo.lock#L766-L768

Not sure if I made it to the most simplified form, as I can hardly speak Rust.

cc @Lucretiel

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/bootandy/dust/pull/436 **Author:** [@muzimuzhi](https://github.com/muzimuzhi) **Created:** 8/30/2024 **Status:** ✅ Merged **Merged:** 9/17/2024 **Merged by:** [@bootandy](https://github.com/bootandy) **Base:** `master` ← **Head:** `simplify-get-terminal-wh` --- ### 📝 Commits (1) - [`c85230a`](https://github.com/bootandy/dust/commit/c85230a4aec00c80983f6ab098d110a528f71c88) refactor: simplify `get_height_of_terminal()` and `get_width...` ### 📊 Changes **1 file changed** (+3 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/main.rs` (+3 -7) </details> ### 📄 Description The https://github.com/eminence/terminal-size/pull/41 PR mentioned in comments of `get_(height|width)_of_terminal()` (added by https://github.com/bootandy/dust/commit/c36ca33fe973657002905bbdb77c639ac3c006f0) https://github.com/bootandy/dust/blob/b63608604a768386506b6736f56092583e8fa5a0/src/main.rs#L83-L91 has been merged and shipped since `terminal-size` [v0.2.2](https://github.com/eminence/terminal-size/releases/tag/v0.2.2). As we're using `terminal-size` v0.2.6 now, it's time to simplify them. https://github.com/bootandy/dust/blob/38c4d237321dcdb4f71f1918ec1cb473ed66655b/Cargo.lock#L766-L768 Not sure if I made it to the most simplified form, as I can hardly speak Rust. cc @Lucretiel --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

zhus added the pull-request label 2026-06-08 11:28:42 +03:00

zhus closed this issue

2026-06-08 11:28:43 +03:00

zhus referenced this issue

2026-06-08 11:28:55 +03:00

[PR #484] [MERGED] fix: all arguments now use '-' instead of '_' #506

Sign in to join this conversation.