[PR #531] [MERGED] fix: dont format filecount when output is set to json #533

Closed
opened 2026-06-08 11:29:10 +03:00 by zhus · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/bootandy/dust/pull/531
Author: @AminurAlam
Created: 10/10/2025
Status: Merged
Merged: 10/13/2025
Merged by: @bootandy

Base: masterHead: master


📝 Commits (1)

  • c8e328d fix: dont format filecount when output is set to json

📊 Changes

2 files changed (+15 additions, -1 deletions)

View changed files

📝 src/display.rs (+10 -0)
📝 src/main.rs (+5 -1)

📄 Description

when calculating filecount the count number is formatted as filesize, this pr fixes that

didnt format the number with a comma because json is usually read by other programs not humans

also added tests that basically return the same number as a string

before vs after

Screenshot_20251010_160715_grim Screenshot_20251010_160848_grim


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bootandy/dust/pull/531 **Author:** [@AminurAlam](https://github.com/AminurAlam) **Created:** 10/10/2025 **Status:** ✅ Merged **Merged:** 10/13/2025 **Merged by:** [@bootandy](https://github.com/bootandy) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`c8e328d`](https://github.com/bootandy/dust/commit/c8e328dbc3157b513e1c2dd13f1545283d99dc5b) fix: dont format filecount when output is set to json ### 📊 Changes **2 files changed** (+15 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/display.rs` (+10 -0) 📝 `src/main.rs` (+5 -1) </details> ### 📄 Description when calculating filecount the count number is formatted as filesize, this pr fixes that didnt format the number with a comma because json is usually read by other programs not humans also added tests that basically return the same number as a string ## before vs after <img width="375" height="250" alt="Screenshot_20251010_160715_grim" src="https://github.com/user-attachments/assets/a069a597-2a53-44da-ad0c-92b8629b4dce" /> <img width="" height="250" alt="Screenshot_20251010_160848_grim" src="https://github.com/user-attachments/assets/52461ef8-d5b6-414c-ae3d-940d4d15c0fc" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
zhus added the pull-request label 2026-06-08 11:29:10 +03:00
zhus closed this issue 2026-06-08 11:29:12 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bootandy/archived-dust#533