sigoden/dufs
1
0
Fork 0
mirror of https://github.com/sigoden/dufs.git synced 2026-04-08 16:49:02 +03:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[GH-ISSUE #402] Return error 400 for unsupported propfind depths #214

New Issue
Closed
opened 2026-04-08 16:51:13 +03:00 by zhus · 2 comments
zhus commented 2026-04-08 16:51:13 +03:00
Owner
Copy Link

Originally created by @grote on GitHub (Jun 14, 2024).
Original GitHub issue: https://github.com/sigoden/dufs/issues/402

I understand this is a minimal implementation, not fully implementing all spec, but here's a tiny reasonable request:

Return error 400 for unsupported propfind depths (I guess anything other than 0 and 1) like nginx does. The depth is in the header and should be readily available.

Related to https://github.com/sigoden/dufs/issues/387

Originally created by @grote on GitHub (Jun 14, 2024). Original GitHub issue: https://github.com/sigoden/dufs/issues/402 I understand this is a minimal implementation, not fully implementing all spec, but here's a tiny reasonable request: Return error `400` for unsupported propfind depths (I guess anything other than `0` and `1`) like nginx does. The depth is in the header and should be readily available. Related to https://github.com/sigoden/dufs/issues/387
zhus closed this issue 2026-04-08 16:51:13 +03:00
zhus commented 2026-04-08 16:51:14 +03:00
Author
Owner
Copy Link

@grote commented on GitHub (Jun 14, 2024):

I don't really know rust, but looks like this is already returned for missing depths here: dc7a7cbb3f/src/server.rs (L964-L973)

<!-- gh-comment-id:2167888038 --> @grote commented on GitHub (Jun 14, 2024): I don't really know rust, but looks like this is already returned for missing depths here: https://github.com/sigoden/dufs/blob/dc7a7cbb3f0f19441152de036c5bc904dc9186e3/src/server.rs#L964-L973
zhus commented 2026-04-08 16:51:14 +03:00
Author
Owner
Copy Link

@grote commented on GitHub (Jun 14, 2024):

Awesome, thanks a lot for the quick fix!

<!-- gh-comment-id:2168151873 --> @grote commented on GitHub (Jun 14, 2024): Awesome, thanks a lot for the quick fix!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
zhus
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigoden/dufs#214
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?