mirror of
https://github.com/sigoden/dufs.git
synced 2026-04-08 16:49:02 +03:00
[GH-ISSUE #435] Suggestion: Drag n drop to download #237
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Mahonzu on GitHub (Aug 21, 2024).
Original GitHub issue: https://github.com/sigoden/dufs/issues/435
Specific Demand
If you drag n drop any direct link to a file into a folder on your system, browser will download file from to that folder. Example: "raw" button in github. This is very useful as it eliminates the need to select a folder when downloading. I would like to have this option in dufs.
Implement Suggestion
Make these links dragable

@sigoden commented on GitHub (Aug 21, 2024):
@ilia-21
I don't understand your request. Could you provide a demonstration video?
@Mahonzu commented on GitHub (Aug 21, 2024):
Sure!
https://github.com/user-attachments/assets/30d2315e-dea4-487c-abd0-486cc05934da
I remember this working on windows too
@sigoden commented on GitHub (Aug 21, 2024):
@ilia-21
It's just a feature of the file browser itself. I've tried it on both LinuxMint and Windows, but it didn't work. It only generated an HTML link.
Have you tried dufs links? I don't think they are much different from GitHub raw links? Both can be clicked to open source files in a browser.
@Mahonzu commented on GitHub (Aug 21, 2024):
Yes, I tried dufs links, but they don't drag at all. When I try to drag them, they don't do anything, as if dragging is disabled in the code.
Just to clarify: the problem is not "I'm dragging, but files are not downloading", the problem is "Links are not dragable"
@sigoden commented on GitHub (Aug 21, 2024):
@ilia-21
How your tried text file like
.mdor.txt? Maybe the file format matter.@Mahonzu commented on GitHub (Aug 21, 2024):
Yes, I tried, none of the links are dragable.
Question: are they dragable on your side? Can you repeat the same as I showed with "raw" button, but in dufs, even if it only generates HTML link? If yes that means the problem is on my side
EDIT: I tested myself, and removing
dragstarton this line makes links dragable, also suggested feature works as expected1db263efae/assets/index.js (L491)EDIT2: In my test removing
dragstartdoes not break drag n drop upload feature. Tested in Firefox 129.0b9@sigoden commented on GitHub (Aug 21, 2024):
This function is not universal and doesn't even work properly in Windows.
https://github.com/user-attachments/assets/387e12d4-a519-494f-bce4-2d45b7d2673a
I have no way to confirm the effect. If it's just removing
dragstart, you can submit a PR.@Mahonzu commented on GitHub (Aug 21, 2024):
If it's not working in windows I can assume that not much people know/need it. I'll try to find a way to modify it locally.
Thank you for making this amazing software and for your time. Closing