[GH-ISSUE #582] Handle log file rotation, for example on SIGHUP #343

New Issue

zhus · 2026-04-08T16:52:12+03:00

zhus commented

2026-04-08 16:52:12 +03:00

Originally created by @g-v-egidy on GitHub (May 11, 2025).
Original GitHub issue: https://github.com/sigoden/dufs/issues/582

Specific Demand

When dufs is running for a longer time you may want to rotate it's logfile. Optimally without interrupting service. There should either be a way to notify dufs about the logfile rotation or it should find out itself automatically.

dufs --log-file ./test.log . &
curl -o /dev/null --silent http://127.0.0.1:5000/
cat test.log
mv test.log test2.log
curl -o /dev/null --silent http://127.0.0.1:5000/

cat test.log
# this now returns: cat: test.log: No such file or directory

cat test2.log
# this shows both requests and not just the first one

pkill -HUP dufs
[1]+  Hangup                  dufs --log-file ./test.log .
# the dufs process is terminated at this point, as there is no SIGHUP handler implemented yet.

Implement Suggestion

It is very common for daemons to reopen the logfile on receiving a SIGHUP signal.

Another way would be to stat the log filename before logging each entry and comparing it with the inode of the opened logfile to detect a change.

But there are probably other ways for detecting log file rotation too.

Originally created by @g-v-egidy on GitHub (May 11, 2025). Original GitHub issue: https://github.com/sigoden/dufs/issues/582 ## Specific Demand When dufs is running for a longer time you may want to rotate it's logfile. Optimally without interrupting service. There should either be a way to notify dufs about the logfile rotation or it should find out itself automatically. ``` dufs --log-file ./test.log . & curl -o /dev/null --silent http://127.0.0.1:5000/ cat test.log mv test.log test2.log curl -o /dev/null --silent http://127.0.0.1:5000/ cat test.log # this now returns: cat: test.log: No such file or directory cat test2.log # this shows both requests and not just the first one pkill -HUP dufs [1]+ Hangup dufs --log-file ./test.log . # the dufs process is terminated at this point, as there is no SIGHUP handler implemented yet. ``` ## Implement Suggestion It is very common for daemons to reopen the logfile on receiving a SIGHUP signal. Another way would be to stat the log filename before logging each entry and comparing it with the inode of the opened logfile to detect a change. But there are probably other ways for detecting log file rotation too.

zhus closed this issue

2026-04-08 16:52:12 +03:00

zhus commented

2026-04-08 16:52:13 +03:00

@sigoden commented on GitHub (May 12, 2025):

dufs is just a simple file server, and we don't think it's necessary to support such complex logging features.

@sigoden commented on GitHub (May 12, 2025): dufs is just a simple file server, and we don't think it's necessary to support such complex logging features.

zhus referenced this issue

2026-04-08 16:53:29 +03:00

[PR #343] [MERGED] feat: supports resumable uploads #574

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sigoden/dufs#343