[GH-ISSUE #94] retry when upload fail #40

Closed
opened 2026-04-08 16:50:00 +03:00 by zhus · 9 comments
Owner

Originally created by @leolulu on GitHub (Jul 5, 2022).
Original GitHub issue: https://github.com/sigoden/dufs/issues/94

while uploading a whole folder, some files may fail.
image
Maybe a retry button could be helpful, or auto retry could be better.

Originally created by @leolulu on GitHub (Jul 5, 2022). Original GitHub issue: https://github.com/sigoden/dufs/issues/94 while uploading a whole folder, some files may fail. ![image](https://user-images.githubusercontent.com/35873316/177245888-64eb6fd0-adfa-482d-bb44-7734aff0cc2e.png) Maybe a retry button could be helpful, or auto retry could be better.
zhus closed this issue 2026-04-08 16:50:00 +03:00
Author
Owner

@sigoden commented on GitHub (Jul 5, 2022):

why so many failures, could you post logs?

I don't support retries because:

  1. Failure is a rare case.
  2. Re-upload requires allow-delete.
<!-- gh-comment-id:1174587577 --> @sigoden commented on GitHub (Jul 5, 2022): why so many failures, could you post logs? I don't support retries because: 1. Failure is a rare case. 2. Re-upload requires `allow-delete`.
Author
Owner

@leolulu commented on GitHub (Jul 5, 2022):

weird. I did the identical uploading again, and got two failures.

……
……
Duplicate.Cleaner.Pro.5.16.0.0/Magick.NET-Q8-AnyCPU.dll ✗
……
……
Duplicate.Cleaner.Pro.5.16.0.0/x64/SQLite.Interop.dll ✗
……
……

Then the log during this uploading:

……
……
[2022-07-05T05:21:13.130Z INFO] 192.168.123.221 "PUT /Duplicate.Cleaner.Pro.5.16.0.0/Magick.NET-Q8-AnyCPU.dll" - 201
……
……
[2022-07-05T05:22:39.590Z INFO] 192.168.123.221 "PUT /Duplicate.Cleaner.Pro.5.16.0.0/x86/SQLite.Interop.dll" - 201
……
……

Finally after I refresh the web page, these files do exists, so are in the local file system.
Seems the error only appears on the web page.

<!-- gh-comment-id:1174640186 --> @leolulu commented on GitHub (Jul 5, 2022): weird. I did the identical uploading again, and got two failures. ``` …… …… Duplicate.Cleaner.Pro.5.16.0.0/Magick.NET-Q8-AnyCPU.dll ✗ …… …… Duplicate.Cleaner.Pro.5.16.0.0/x64/SQLite.Interop.dll ✗ …… …… ``` Then the log during this uploading: ``` …… …… [2022-07-05T05:21:13.130Z INFO] 192.168.123.221 "PUT /Duplicate.Cleaner.Pro.5.16.0.0/Magick.NET-Q8-AnyCPU.dll" - 201 …… …… [2022-07-05T05:22:39.590Z INFO] 192.168.123.221 "PUT /Duplicate.Cleaner.Pro.5.16.0.0/x86/SQLite.Interop.dll" - 201 …… …… ``` Finally after I refresh the web page, these files do exists, so are in the local file system. Seems the error only appears on the web page.
Author
Owner

@sigoden commented on GitHub (Jul 5, 2022):

ui should not show failure if log shows success.

Could you open webdev tools and take a screenshot of the network/console panel?

<!-- gh-comment-id:1174679462 --> @sigoden commented on GitHub (Jul 5, 2022): ui should not show failure if log shows success. Could you open webdev tools and take a screenshot of the network/console panel?
Author
Owner

@leolulu commented on GitHub (Jul 5, 2022):

sure, I take one of the failures as example.

web page result:
Duplicate.Cleaner.Pro.5.16.0.0/Magick.NET.Core.dll ✗

backend log:
[2022-07-05T10:27:48.897Z INFO] 192.168.123.221 "PUT /Duplicate.Cleaner.Pro.5.16.0.0/Magick.NET.Core.dll" - 201

webdev network:
image

webdev console:
image

<!-- gh-comment-id:1174908187 --> @leolulu commented on GitHub (Jul 5, 2022): sure, I take one of the failures as example. web page result: Duplicate.Cleaner.Pro.5.16.0.0/Magick.NET.Core.dll ✗ backend log: [2022-07-05T10:27:48.897Z INFO] 192.168.123.221 "PUT /Duplicate.Cleaner.Pro.5.16.0.0/Magick.NET.Core.dll" - 201 webdev network: ![image](https://user-images.githubusercontent.com/35873316/177309707-19e78e10-6e6b-4df9-a7ea-5a7bc47a3596.png) webdev console: ![image](https://user-images.githubusercontent.com/35873316/177310079-c68796ce-c5c0-4493-a69b-da752357d099.png)
Author
Owner

@sigoden commented on GitHub (Jul 5, 2022):

dufs never returns 502. Are your run dufs behind a proxy?

<!-- gh-comment-id:1174916916 --> @sigoden commented on GitHub (Jul 5, 2022): dufs never returns 502. Are your run dufs behind a proxy?
Author
Owner

@leolulu commented on GitHub (Jul 5, 2022):

Yes, I deploy dufs on my local machine, and expose the service through frp(a reverse proxy).
Then access by the public ip and port.
Could this be the reason?

<!-- gh-comment-id:1174922090 --> @leolulu commented on GitHub (Jul 5, 2022): Yes, I deploy dufs on my local machine, and expose the service through frp(a reverse proxy). Then access by the public ip and port. Could this be the reason?
Author
Owner

@sigoden commented on GitHub (Jul 5, 2022):

The probability of upload failure is related to network quality and concurrency.

You can test whether reducing the concurrency can improve the upload success rate.

<!-- gh-comment-id:1174929800 --> @sigoden commented on GitHub (Jul 5, 2022): The probability of upload failure is related to network quality and concurrency. You can test whether reducing the concurrency can improve the upload success rate.
Author
Owner

@leolulu commented on GitHub (Jul 5, 2022):

sure, I will try.
And Since it's not the problem of program itself, I think this thread could be closed.
Thanks for your tech support :)

<!-- gh-comment-id:1174936190 --> @leolulu commented on GitHub (Jul 5, 2022): sure, I will try. And Since it's not the problem of program itself, I think this thread could be closed. Thanks for your tech support :)
Author
Owner

@sigoden commented on GitHub (Jul 5, 2022):

Issue #95 is open to handle concurrency.

<!-- gh-comment-id:1174941439 --> @sigoden commented on GitHub (Jul 5, 2022): Issue #95 is open to handle concurrency.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigoden/dufs#40