mirror of
https://github.com/sigoden/dufs.git
synced 2026-04-08 16:49:02 +03:00
[GH-ISSUE #106] symbolic links to external drives are not listed #47
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @notjedi on GitHub (Jul 17, 2022).
Original GitHub issue: https://github.com/sigoden/dufs/issues/106
Problem
as the title suggests, symbolic links linked to external disks are not listed.
Environment:
0.26.0braveon android andlibrewolfon linuxArch Linux@notjedi commented on GitHub (Jul 17, 2022):
similar projects that are not suffering from this issue:
@notjedi commented on GitHub (Jul 17, 2022):
i can see that both the projects do something similar with
fs::read_link, whichdufsdoes not. here is a link to those lines:7c1fa0e7bb/src/ops/webdav.rs (L148-L161)55a23fa497/src/listing.rs (L248-L251)@sigoden commented on GitHub (Jul 17, 2022):
Do your run with option
-Aor--allow-symlink?@notjedi commented on GitHub (Jul 17, 2022):
it works after passing the
-Aoption. but i think it makes more sense to allow symlinks by default. also there is lack of consistency here, because symlinks within the same drive are listed without the-Aoption.@sigoden commented on GitHub (Jul 17, 2022):
For security, dufs don't allow symlinks to dirctories outside the entrypoint directory unless runing with option
-Aor--allow-symlink.For convenient, dufs do allow symlinks to directories inside the entrypoint directory.
These will satisfy most users.
@notjedi commented on GitHub (Jul 17, 2022):
cool, understood. but, do you mind telling me about the security concerns when it comes to external symlinks?
@sigoden commented on GitHub (Jul 18, 2022):
If you only want to serve a certain directory, but that directory has an symlink which links to /, you are actually exposing the entire filesystem.