[PR #279] [MERGED] feat: deprecate --auth-method, as both options are available #544

Closed
opened 2026-04-08 16:53:22 +03:00 by zhus · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/sigoden/dufs/pull/279
Author: @sigoden
Created: 11/3/2023
Status: Merged
Merged: 11/3/2023
Merged by: @sigoden

Base: mainHead: feat-auth


📝 Commits (2)

  • 010f080 feat: deprecate --auth-method, both are avaiable
  • f4275f3 send one www-authenticate with two scheme

📊 Changes

7 files changed (+130 additions, -172 deletions)

View changed files

📝 README.md (+2 -4)
📝 src/args.rs (+1 -7)
📝 src/auth.rs (+107 -132)
📝 src/log_http.rs (+5 -7)
📝 src/server.rs (+9 -16)
📝 tests/auth.rs (+3 -3)
📝 tests/log_http.rs (+3 -3)

📄 Description

In request, we auto detect auth method from Authorization Header.

Basic ...        basic auth
Digest ...       digest auth

In response, we set a www-authenticate headers with both schema:

www-authenticate: Digest realm="DUFS", nonce="6544e916ba36090e25ebe3cb000be8b7d3", qop="auth", Basic realm="DUFS"

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/sigoden/dufs/pull/279 **Author:** [@sigoden](https://github.com/sigoden) **Created:** 11/3/2023 **Status:** ✅ Merged **Merged:** 11/3/2023 **Merged by:** [@sigoden](https://github.com/sigoden) **Base:** `main` ← **Head:** `feat-auth` --- ### 📝 Commits (2) - [`010f080`](https://github.com/sigoden/dufs/commit/010f0801120fcdfc047537f5da5a6dad50a7016e) feat: deprecate `--auth-method`, both are avaiable - [`f4275f3`](https://github.com/sigoden/dufs/commit/f4275f34dc4757afecc41a3506cc6265c3a73415) send one www-authenticate with two scheme ### 📊 Changes **7 files changed** (+130 additions, -172 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+2 -4) 📝 `src/args.rs` (+1 -7) 📝 `src/auth.rs` (+107 -132) 📝 `src/log_http.rs` (+5 -7) 📝 `src/server.rs` (+9 -16) 📝 `tests/auth.rs` (+3 -3) 📝 `tests/log_http.rs` (+3 -3) </details> ### 📄 Description In request, we auto detect auth method from Authorization Header. ``` Basic ... basic auth Digest ... digest auth ``` In response, we set a www-authenticate headers with both schema: ``` www-authenticate: Digest realm="DUFS", nonce="6544e916ba36090e25ebe3cb000be8b7d3", qop="auth", Basic realm="DUFS" ```` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
zhus added the pull-request label 2026-04-08 16:53:22 +03:00
zhus closed this issue 2026-04-08 16:53:22 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigoden/dufs#544