[PR #312] [MERGED] refactor: change the format of www-authenticate #560

Closed
opened 2026-04-08 16:53:26 +03:00 by zhus · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/sigoden/dufs/pull/312
Author: @sigoden
Created: 12/7/2023
Status: Merged
Merged: 12/7/2023
Merged by: @sigoden

Base: mainHead: refactor-www-authenticate


📝 Commits (1)

  • 1d8c9b2 refactor: change the format of www-authenticate

📊 Changes

3 files changed (+28 additions, -17 deletions)

View changed files

📝 src/auth.rs (+16 -12)
📝 src/server.rs (+3 -4)
📝 tests/auth.rs (+9 -1)

📄 Description

Some webdav client's (like microsoft-webdav) don't support multi-changes in single www-authenticate header as follows:

www-authenticate: Digest realm="DUFS", nonce="6571013fd6b54c9f061bd40b9587721040", qop="auth", Basic realm="DUFS"

Refactor this into two separate "www-authenticate" headers:

www-authenticate: Digest realm="DUFS", nonce="6571013fd6b54c9f061bd40b9587721040", qop="auth"
www-authenticate: Basic realm="DUFS"

close #307


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/sigoden/dufs/pull/312 **Author:** [@sigoden](https://github.com/sigoden) **Created:** 12/7/2023 **Status:** ✅ Merged **Merged:** 12/7/2023 **Merged by:** [@sigoden](https://github.com/sigoden) **Base:** `main` ← **Head:** `refactor-www-authenticate` --- ### 📝 Commits (1) - [`1d8c9b2`](https://github.com/sigoden/dufs/commit/1d8c9b2445275af7e09789157c6479f604cf6d71) refactor: change the format of www-authenticate ### 📊 Changes **3 files changed** (+28 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `src/auth.rs` (+16 -12) 📝 `src/server.rs` (+3 -4) 📝 `tests/auth.rs` (+9 -1) </details> ### 📄 Description Some webdav client's (like microsoft-webdav) don't support multi-changes in single `www-authenticate` header as follows: ``` www-authenticate: Digest realm="DUFS", nonce="6571013fd6b54c9f061bd40b9587721040", qop="auth", Basic realm="DUFS" ``` Refactor this into two separate "www-authenticate" headers: ``` www-authenticate: Digest realm="DUFS", nonce="6571013fd6b54c9f061bd40b9587721040", qop="auth" www-authenticate: Basic realm="DUFS" ``` close #307 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
zhus added the pull-request label 2026-04-08 16:53:26 +03:00
zhus closed this issue 2026-04-08 16:53:26 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigoden/dufs#560