sigoden/dufs
1
0
Fork 0
mirror of https://github.com/sigoden/dufs.git synced 2026-04-08 16:49:02 +03:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #352] [MERGED] feat: revert supporting for forbidden permission #577

New Issue
Closed
opened 2026-04-08 16:53:30 +03:00 by zhus · 0 comments
zhus commented 2026-04-08 16:53:30 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/sigoden/dufs/pull/352
Author: @sigoden
Created: 1/17/2024
Status: ✅ Merged
Merged: 1/17/2024
Merged by: @sigoden

Base: main ← Head: feat-revert-forbid

📝 Commits (1)

  • efab84b feat: revert support for forbidden permission

📊 Changes

4 files changed (+14 additions, -42 deletions)

View changed files

📝 README.md (+3 -3)
📝 src/auth.rs (+9 -20)
📝 src/server.rs (+2 -2)
📝 tests/auth.rs (+0 -17)

📄 Description

#329 supports forbidden permission, but this pr reverts it.

why revert? becase many operations are anti-pattern and difficult to process. Take /dir1:rw,/dir1/dir2:rw as an example.

  • When deleting /dir1, should /dir1/dir2 be deleted?
  • When moving /dir1, should /dir1/dir2 be moved?
  • When zip downloading /dir1, do you need to include /dir1/dir2?
  • After renaming /dir1, the constraints of /dir1/dir2 fail. What should I do?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/sigoden/dufs/pull/352 **Author:** [@sigoden](https://github.com/sigoden) **Created:** 1/17/2024 **Status:** ✅ Merged **Merged:** 1/17/2024 **Merged by:** [@sigoden](https://github.com/sigoden) **Base:** `main` ← **Head:** `feat-revert-forbid` --- ### 📝 Commits (1) - [`efab84b`](https://github.com/sigoden/dufs/commit/efab84bcbcaf54651b55553e56ebf09cdc033262) feat: revert support for forbidden permission ### 📊 Changes **4 files changed** (+14 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+3 -3) 📝 `src/auth.rs` (+9 -20) 📝 `src/server.rs` (+2 -2) 📝 `tests/auth.rs` (+0 -17) </details> ### 📄 Description #329 supports forbidden permission, but this pr reverts it. why revert? becase many operations are anti-pattern and difficult to process. Take `/dir1:rw,/dir1/dir2:rw` as an example. - When deleting `/dir1`, should `/dir1/dir2` be deleted? - When moving `/dir1`, should `/dir1/dir2` be moved? - When zip downloading `/dir1`, do you need to include `/dir1/dir2`? - After renaming `/dir1`, the constraints of `/dir1/dir2` fail. What should I do? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
zhus added the pull-request label 2026-04-08 16:53:30 +03:00
zhus closed this issue 2026-04-08 16:53:30 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
zhus
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigoden/dufs#577
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?