sigoden/dufs
1
0
Fork 0
mirror of https://github.com/sigoden/dufs.git synced 2026-04-08 16:49:02 +03:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #391] [MERGED] refactor: no inline scripts in HTML #599

New Issue
Closed
opened 2026-04-08 16:53:36 +03:00 by zhus · 0 comments
zhus commented 2026-04-08 16:53:36 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/sigoden/dufs/pull/391
Author: @need4swede
Created: 5/30/2024
Status: ✅ Merged
Merged: 5/31/2024
Merged by: @sigoden

Base: main ← Head: no-inline-scripts

📝 Commits (7)

📊 Changes

6 files changed (+81 additions, -59 deletions)

View changed files

📝 assets/index.css (+2 -2)
📝 assets/index.html (+4 -8)
📝 assets/index.js (+60 -44)
📝 tests/assets.rs (+1 -1)
📝 tests/fixtures.rs (+1 -1)
📝 tests/utils.rs (+13 -3)

📄 Description

Moved all inline <script> tags out from HTML and into index.js
This was done to adhere to strict Content-Security-Policy protocols that disallow inline-scripts.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/sigoden/dufs/pull/391 **Author:** [@need4swede](https://github.com/need4swede) **Created:** 5/30/2024 **Status:** ✅ Merged **Merged:** 5/31/2024 **Merged by:** [@sigoden](https://github.com/sigoden) **Base:** `main` ← **Head:** `no-inline-scripts` --- ### 📝 Commits (7) - [`3f4a775`](https://github.com/sigoden/dufs/commit/3f4a7752710c50cfd2ec68d06c561a6fdafabaa0) Moved 'ready' func call from index.html - [`86a91dc`](https://github.com/sigoden/dufs/commit/86a91dc1bf5c6f89a19b5e70a2e17e0854a4bdf5) Moved <script> out from index.html - [`8ee0fb0`](https://github.com/sigoden/dufs/commit/8ee0fb045c91eefe49aee6690a9a425a1b1c3a55) moved inline-styling to css - [`811f1b7`](https://github.com/sigoden/dufs/commit/811f1b71b2d47eb4994392c23752b23b7c44bca6) minor formatting changes - [`6e4da5f`](https://github.com/sigoden/dufs/commit/6e4da5ffeedcc2e9ef07cd486111dc8473e7958f) changed ratio from const to let - [`cf19124`](https://github.com/sigoden/dufs/commit/cf19124afd1e496cf3e9b24a7ab8e266cd72a7e1) refactor - [`cd3c807`](https://github.com/sigoden/dufs/commit/cd3c807a2644767bafd889fb00d6a105d53d6e02) fix tests ### 📊 Changes **6 files changed** (+81 additions, -59 deletions) <details> <summary>View changed files</summary> 📝 `assets/index.css` (+2 -2) 📝 `assets/index.html` (+4 -8) 📝 `assets/index.js` (+60 -44) 📝 `tests/assets.rs` (+1 -1) 📝 `tests/fixtures.rs` (+1 -1) 📝 `tests/utils.rs` (+13 -3) </details> ### 📄 Description Moved all inline <script> tags out from HTML and into index.js This was done to adhere to strict Content-Security-Policy protocols that disallow inline-scripts. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
zhus added the pull-request label 2026-04-08 16:53:36 +03:00
zhus closed this issue 2026-04-08 16:53:36 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
zhus
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigoden/dufs#599
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?