sigoden/dufs
1
0
Fork 0
mirror of https://github.com/sigoden/dufs.git synced 2026-06-07 23:16:54 +03:00
Code Issues 67 Packages Projects Releases 10 Wiki Activity

[PR #693] [MERGED] Feature: confirm on exit while uploading #6221

New Issue
Closed
opened 2026-05-29 23:51:46 +03:00 by zhus · 0 comments
zhus commented 2026-05-29 23:51:46 +03:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/sigoden/dufs/pull/693
Author: @florinm03
Created: 4/25/2026
Status: ✅ Merged
Merged: 4/25/2026
Merged by: @sigoden

Base: main ← Head: feat/confirm-on-exit

📝 Commits (5)

📊 Changes

1 file changed (+11 additions, -0 deletions)

View changed files

📝 assets/index.js (+11 -0)

📄 Description

Hey, we have noticed, that there is no confirmation when closing the tab and an upload is not finished. This can result in an unnecessary cancel of the upload. Can be quite frustrating when you are at 90% out of 6GB. :)

Solution
Added the event listener for it.

Tested on:

  • Edge
  • Chrome
  • Safari
  • Brave(MacOS)
  • Brave on windows does not show it at all. But this is rather their implementation not reacting to the event. I'll open an issue there to see what's up, but in the end the implementation should not differ.
  • Maybe you have firefox to test it on.

@sigoden Lmk what you think. Hope this gets merged, because we would really need it. :)

image Here an example of the displayed box. Tried adding a custom message, but browsers seem to ignore it for security reasons.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/sigoden/dufs/pull/693 **Author:** [@florinm03](https://github.com/florinm03) **Created:** 4/25/2026 **Status:** ✅ Merged **Merged:** 4/25/2026 **Merged by:** [@sigoden](https://github.com/sigoden) **Base:** `main` ← **Head:** `feat/confirm-on-exit` --- ### 📝 Commits (5) - [`e8c73e9`](https://github.com/sigoden/dufs/commit/e8c73e9ab4f5edc9c152263a135e8e056d94ec57) feature: confirm box before exiting while uploading - [`e577983`](https://github.com/sigoden/dufs/commit/e5779839737b4ed7b88a37e5bb87643212a17490) Merge branch 'sigoden:main' into feat/confirm-on-exit - [`a1407a6`](https://github.com/sigoden/dufs/commit/a1407a6b7ec467e6f3e8c64debb1ff25184e4584) remove unused message - [`1559f83`](https://github.com/sigoden/dufs/commit/1559f83227d6280d3cc0d5c8d2130963b90d1c89) Merge branch 'feat/confirm-on-exit' of https://github.com/florinm03/dufs into feat/confirm-on-exit - [`11fe826`](https://github.com/sigoden/dufs/commit/11fe8260cb1bcd0f17ed7acf8cea6aadc60b8f31) Merge branch 'sigoden:main' into feat/confirm-on-exit ### 📊 Changes **1 file changed** (+11 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `assets/index.js` (+11 -0) </details> ### 📄 Description Hey, we have noticed, that there is no confirmation when closing the tab and an upload is not finished. This can result in an unnecessary cancel of the upload. Can be quite frustrating when you are at 90% out of 6GB. :) **Solution** Added the event listener for it. **Tested on:** - Edge - Chrome - Safari - Brave(MacOS) - Brave on windows does not show it at all. But this is rather their implementation not reacting to the event. I'll open an issue there to see what's up, but in the end the implementation should not differ. - Maybe you have firefox to test it on. @sigoden Lmk what you think. Hope this gets merged, because we would really need it. :) *** <img width="449" height="147" alt="image" src="https://github.com/user-attachments/assets/8d9aa332-8527-4d31-a961-b77916628662" /> Here an example of the displayed box. Tried adding a custom message, but browsers seem to ignore it for security reasons. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
zhus added the pull-request label 2026-05-29 23:51:46 +03:00
zhus closed this issue 2026-05-29 23:51:47 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
zhus (Sergey Zhukov)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigoden/dufs#6221
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?