sigoden/dufs
1
0
Fork 0
mirror of https://github.com/sigoden/dufs.git synced 2026-04-08 16:49:02 +03:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #572] [MERGED] Follow symlinks when searching/archiving #646

New Issue
Closed
opened 2026-04-08 16:53:48 +03:00 by zhus · 0 comments
zhus commented 2026-04-08 16:53:48 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/sigoden/dufs/pull/572
Author: @falko17
Created: 4/10/2025
Status: ✅ Merged
Merged: 4/12/2025
Merged by: @sigoden

Base: main ← Head: follow-symlinks-search-archive

📝 Commits (1)

  • 102a738 fix: follow symlinks when searching/archiving

📊 Changes

1 file changed (+83 additions, -60 deletions)

View changed files

📝 src/server.rs (+83 -60)

📄 Description

Specifically, this will always follow symlinks when they lead to a path below the dufs root, and will follow other symlinks when --allow-symlink is set. This is cherry-picked and modified1 from #566.

(I additionally refactored some common functionality out of zip_dir and handle_search_dir.)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

  1. Compared to the original implementation, this no longer introduces a new parameter, nor does it prevent symlinks whose target is under the dufs root from being followed when --allow-symlink is not set. ↩︎

## 📋 Pull Request Information **Original PR:** https://github.com/sigoden/dufs/pull/572 **Author:** [@falko17](https://github.com/falko17) **Created:** 4/10/2025 **Status:** ✅ Merged **Merged:** 4/12/2025 **Merged by:** [@sigoden](https://github.com/sigoden) **Base:** `main` ← **Head:** `follow-symlinks-search-archive` --- ### 📝 Commits (1) - [`102a738`](https://github.com/sigoden/dufs/commit/102a73817b6a9d62b3b48fb45185fb8e3620d229) fix: follow symlinks when searching/archiving ### 📊 Changes **1 file changed** (+83 additions, -60 deletions) <details> <summary>View changed files</summary> 📝 `src/server.rs` (+83 -60) </details> ### 📄 Description Specifically, this will always follow symlinks when they lead to a path below the dufs root, and will follow other symlinks when `--allow-symlink` is set. This is cherry-picked and modified[^1] from #566. (I additionally refactored some common functionality out of `zip_dir` and `handle_search_dir`.) [^1]: Compared to the original implementation, this no longer introduces a new parameter, nor does it prevent symlinks whose target is under the dufs root from being followed when `--allow-symlink` is not set. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
zhus added the pull-request label 2026-04-08 16:53:48 +03:00
zhus closed this issue 2026-04-08 16:53:48 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
zhus
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigoden/dufs#646
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?