sigoden/dufs
1
0
Fork 0
mirror of https://github.com/sigoden/dufs.git synced 2026-04-08 16:49:02 +03:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #619] [MERGED] fix: perms on dufs -A -a @/:ro #659

New Issue
Closed
opened 2026-04-08 16:53:51 +03:00 by zhus · 0 comments
zhus commented 2026-04-08 16:53:51 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/sigoden/dufs/pull/619
Author: @sigoden
Created: 8/19/2025
Status: ✅ Merged
Merged: 8/19/2025
Merged by: @sigoden

Base: main ← Head: fix

📝 Commits (1)

  • 8ca6067 fix: perms on dufs -A -a @/:ro

📊 Changes

3 files changed (+26 additions, -5 deletions)

View changed files

📝 src/auth.rs (+6 -3)
📝 src/server.rs (+2 -2)
📝 tests/auth.rs (+18 -0)

📄 Description

This bug let annoymous user has read-write permissions.

To trigger this bug, the following conditions must be met:

  • The -A or --allow-upload/--allow-delete parameter must be present.
  • Only -a @/:ro is set to specify anonymous readonly permission, without any users provided.

The bug was introduced by #497.

Relate to #617.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/sigoden/dufs/pull/619 **Author:** [@sigoden](https://github.com/sigoden) **Created:** 8/19/2025 **Status:** ✅ Merged **Merged:** 8/19/2025 **Merged by:** [@sigoden](https://github.com/sigoden) **Base:** `main` ← **Head:** `fix` --- ### 📝 Commits (1) - [`8ca6067`](https://github.com/sigoden/dufs/commit/8ca6067ed20f9d9280414bd83165a271e065184d) fix: perms on `dufs -A -a @/:ro` ### 📊 Changes **3 files changed** (+26 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/auth.rs` (+6 -3) 📝 `src/server.rs` (+2 -2) 📝 `tests/auth.rs` (+18 -0) </details> ### 📄 Description This bug let annoymous user has read-write permissions. To trigger this bug, the following conditions must be met: - The `-A` or `--allow-upload/--allow-delete` parameter must be present. - Only `-a @/:ro` is set to specify anonymous readonly permission, without any users provided. The bug was introduced by #497. Relate to #617. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
zhus added the pull-request label 2026-04-08 16:53:51 +03:00
zhus closed this issue 2026-04-08 16:53:51 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
zhus
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigoden/dufs#659
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?