[PR #666] [CLOSED] disable iframe sandboxing to fix PDF embedding #671

New Issue

zhus · 2026-04-08T16:53:55+03:00

zhus commented

2026-04-08 16:53:55 +03:00

📋 Pull Request Information

Original PR: https://github.com/sigoden/dufs/pull/666
Author: @jamesscottbrown
Created: 1/22/2026
Status: ❌ Closed

Base: main ← Head: patch-1

📝 Commits (1)

461436c disable iframe sandboxing to fix PDF embedding

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 assets/index.js (+1 -1)

📄 Description

Applying the the sandbox attribute to an iFrame but with an empty value applies all sandboxing restrictions to the iFrame, and this prevents the PDF preview on Edit/View (?edit/?view) pages from working (this problem was reported as https://github.com/sigoden/dufs/issues/648).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/sigoden/dufs/pull/666 **Author:** [@jamesscottbrown](https://github.com/jamesscottbrown) **Created:** 1/22/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`461436c`](https://github.com/sigoden/dufs/commit/461436ccf16745ca386c705a0d664436d8cffe47) disable iframe sandboxing to fix PDF embedding ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `assets/index.js` (+1 -1) </details> ### 📄 Description Applying the the `sandbox` attribute to an iFrame but with an empty value applies all sandboxing restrictions to the iFrame, and this prevents the PDF preview on Edit/View (`?edit`/`?view`) pages from working (this problem was reported as https://github.com/sigoden/dufs/issues/648). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

zhus added the pull-request label 2026-04-08 16:53:55 +03:00

zhus closed this issue

2026-04-08 16:53:55 +03:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sigoden/dufs#671