mirror of
https://github.com/sigoden/dufs.git
synced 2026-04-08 16:49:02 +03:00
[GH-ISSUE #150] The dufs docker image does not terminate properly #72
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sprat on GitHub (Dec 9, 2022).
Original GitHub issue: https://github.com/sigoden/dufs/issues/150
Problem
The dufs docker image does not terminate properly: the dufs server seems to shutdown only with the Ctrl+C (SIGINT) signal, but docker send a SIGTERM signal to stop the process by default. Since the process does not shut down, docker send a SIGKILL signal after 10s which stops the process without any cleanup.
Either dufs should react to the SIGTERM signal, or the dufs docker image should specify a SIGINT signal as stop signal (via the STOPSIGNAL directive in the Dockerfile).
Log
When I stop the container, it takes 10s to shutdown instead of shutting down immediately.
Environment:
@sprat commented on GitHub (Dec 9, 2022):
Note: I can file a pull request adding the STOPSIGNAL directive if you agree with the approach
@sigoden commented on GitHub (Dec 9, 2022):
welcome to submit a pr to add STOPSIGNAL directive to Dockerfile.
@sprat commented on GitHub (Dec 9, 2022):
done ;)